Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync quickstart projects #16

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Sync quickstart projects #16

merged 5 commits into from
Aug 9, 2024
+2,368 −2,252

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Aug 9, 2024 •
edited
Loading

📬 Changes

  • remove bun (sqlite incompatibility), move towards similar tooling to automation-quickstart
  • sync common workspace elements with other quickstart project
  • upgrade / simplify dependencies
  • docs tweaks
  • moving docs for publish & test to central docs repo where it can be expanded on more
  • introduce canned pm2 ecosystem file + build script based on code runner addon flow

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 214 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (329697a) to head (2e69454).

Files Patch % Lines
src/living-room.ts 0.00% 87 Missing and 1 partial ⚠️
src/main.ts 0.00% 51 Missing and 1 partial ⚠️
src/office.ts 0.00% 43 Missing and 1 partial ⚠️
src/helpers.ts 0.00% 19 Missing and 1 partial ⚠️
pm2.ecosystem.js 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #16       +/-   ##
==========================================
- Coverage   12.85%   0.00%   -12.86%     
==========================================
  Files           3       5        +2     
  Lines         140     236       +96     
  Branches        3       5        +2     
==========================================
- Hits           18       0       -18     
- Misses        120     231      +111     
- Partials        2       5        +3
Files Coverage Δ
pm2.ecosystem.js 0.00% <0.00%> (ø)
src/helpers.ts 0.00% <0.00%> (ø)
src/office.ts 0.00% <0.00%> (ø)
src/main.ts 0.00% <0.00%> (ø)
src/living-room.ts 0.00% <0.00%> (ø)
Files Coverage Δ
pm2.ecosystem.js 0.00% <0.00%> (ø)
src/helpers.ts 0.00% <0.00%> (ø)
src/office.ts 0.00% <0.00%> (ø)
src/main.ts 0.00% <0.00%> (ø)
src/living-room.ts 0.00% <0.00%> (ø)

@zoe-codez zoe-codez merged commit fd17bb7 into main Aug 9, 2024
1 check failed
@zoe-codez zoe-codez deleted the zoe/workspace-sync branch August 9, 2024 17:34
@webbertakken
Copy link
Member

Removal of Bun. Related limitation from Bun: oven-sh/bun#4290

@webbertakken webbertakken mentioned this pull request Aug 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoe-codez @webbertakken